Browse Source

added third & fourth test for readConfig & productive code

feature-pr-BordComputer-readConfig
Jan Ortner 3 years ago
parent
commit
b6a718f728
  1. 2
      src/main/java/BordComputer.java
  2. 10
      src/test/java/BordComputerTest.java

2
src/main/java/BordComputer.java

@ -1,4 +1,5 @@
import java.io.FileReader; import java.io.FileReader;
import java.util.Arrays;
import java.util.Properties; import java.util.Properties;
public class BordComputer { public class BordComputer {
@ -11,6 +12,7 @@ public class BordComputer {
Properties properties = new Properties(); Properties properties = new Properties();
properties.load(reader); properties.load(reader);
String[] values = properties.values().toArray(new String[0]); String[] values = properties.values().toArray(new String[0]);
Arrays.sort(values);
deviceNames = new String[values.length]; deviceNames = new String[values.length];
System.arraycopy(values, 0, deviceNames, 0, properties.size()); System.arraycopy(values, 0, deviceNames, 0, properties.size());
} catch (Exception e) { } catch (Exception e) {

10
src/test/java/BordComputerTest.java

@ -30,6 +30,12 @@ class BordComputerTest {
if (testTyp.equals("item1")) { if (testTyp.equals("item1")) {
assertThat(testBc.deviceNames[0]).describedAs(testName).isEqualTo(expectedResult); assertThat(testBc.deviceNames[0]).describedAs(testName).isEqualTo(expectedResult);
} }
if (testTyp.equals("item2")) {
assertThat(testBc.deviceNames[1]).describedAs(testName).isEqualTo(expectedResult);
}
if (testTyp.equals("item3")) {
assertThat(testBc.deviceNames[2]).describedAs(testName).isEqualTo(expectedResult);
}
} }
static Stream<Arguments> readConfigOptions() { static Stream<Arguments> readConfigOptions() {
@ -38,7 +44,9 @@ class BordComputerTest {
return Stream.of( return Stream.of(
Arguments.of("Check if file reader is getting every item in Geraete.config", "count", bc1, ""), Arguments.of("Check if file reader is getting every item in Geraete.config", "count", bc1, ""),
Arguments.of("Check if file reader is getting the first element", "item1", bc1, "device.cdPlayer.CdPlayer")
Arguments.of("Check if file reader is getting the first element", "item1", bc1, "device.cdPlayer.CdPlayer"),
Arguments.of("Check if file reader is getting the second element", "item2", bc1, "device.radioPlayer.RadioPlayer"),
Arguments.of("Check if file reader is getting the third element", "item3", bc1, "device.usbPlayer.UsbPlayer")
); );
} }
Loading…
Cancel
Save