From b6a718f728bf18ae29019f809fe35852c7a1acc5 Mon Sep 17 00:00:00 2001 From: alpina0707 Date: Thu, 17 Feb 2022 18:28:22 +0100 Subject: [PATCH] added third & fourth test for readConfig & productive code --- src/main/java/BordComputer.java | 2 ++ src/test/java/BordComputerTest.java | 10 +++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/main/java/BordComputer.java b/src/main/java/BordComputer.java index 5b44487..e0af6dc 100644 --- a/src/main/java/BordComputer.java +++ b/src/main/java/BordComputer.java @@ -1,4 +1,5 @@ import java.io.FileReader; +import java.util.Arrays; import java.util.Properties; public class BordComputer { @@ -11,6 +12,7 @@ public class BordComputer { Properties properties = new Properties(); properties.load(reader); String[] values = properties.values().toArray(new String[0]); + Arrays.sort(values); deviceNames = new String[values.length]; System.arraycopy(values, 0, deviceNames, 0, properties.size()); } catch (Exception e) { diff --git a/src/test/java/BordComputerTest.java b/src/test/java/BordComputerTest.java index 034584d..3992b59 100644 --- a/src/test/java/BordComputerTest.java +++ b/src/test/java/BordComputerTest.java @@ -30,6 +30,12 @@ class BordComputerTest { if (testTyp.equals("item1")) { assertThat(testBc.deviceNames[0]).describedAs(testName).isEqualTo(expectedResult); } + if (testTyp.equals("item2")) { + assertThat(testBc.deviceNames[1]).describedAs(testName).isEqualTo(expectedResult); + } + if (testTyp.equals("item3")) { + assertThat(testBc.deviceNames[2]).describedAs(testName).isEqualTo(expectedResult); + } } static Stream readConfigOptions() { @@ -38,7 +44,9 @@ class BordComputerTest { return Stream.of( Arguments.of("Check if file reader is getting every item in Geraete.config", "count", bc1, ""), - Arguments.of("Check if file reader is getting the first element", "item1", bc1, "device.cdPlayer.CdPlayer") + Arguments.of("Check if file reader is getting the first element", "item1", bc1, "device.cdPlayer.CdPlayer"), + Arguments.of("Check if file reader is getting the second element", "item2", bc1, "device.radioPlayer.RadioPlayer"), + Arguments.of("Check if file reader is getting the third element", "item3", bc1, "device.usbPlayer.UsbPlayer") ); }