Browse Source

refactoring: refactored tests and removed redundant condition in splitcommand

main
fdai7374 2 years ago
parent
commit
1367c5072c
  1. 17
      src/builtins/help.rs

17
src/builtins/help.rs

@ -27,7 +27,7 @@ impl Builtin for Help {
} }
fn split_command(commands: &str) -> Vec<&str> { fn split_command(commands: &str) -> Vec<&str> {
if !commands.is_empty() && commands.trim().len() >= 1 {
if commands.trim_start().len() >= 1 {
let splitted_command = commands.trim_start().splitn(2, " ").collect(); let splitted_command = commands.trim_start().splitn(2, " ").collect();
return splitted_command; return splitted_command;
} }
@ -38,24 +38,25 @@ fn split_command(commands: &str) -> Vec<&str> {
mod tests { mod tests {
use super::*; use super::*;
#[test] #[test]
fn test_split_command_split(){
fn test_split_command_split() {
let test_string1 = "Hallo, Marcel Davis 1&1."; let test_string1 = "Hallo, Marcel Davis 1&1.";
assert_eq!(split_command(test_string1),vec!["Hallo,","Marcel Davis 1&1."]);
assert_eq!(split_command(test_string1), vec!["Hallo,", "Marcel Davis 1&1."]);
let test_string2 = "Leiter1 23für Kundenzufriedenheit."; let test_string2 = "Leiter1 23für Kundenzufriedenheit.";
assert_eq!(split_command(test_string2), vec!["Leiter1", "23für Kundenzufriedenheit."]); assert_eq!(split_command(test_string2), vec!["Leiter1", "23für Kundenzufriedenheit."]);
let test_string3 = "Wir# $%gehen erst wieder, wenn ihre Leitung läuft!"; let test_string3 = "Wir# $%gehen erst wieder, wenn ihre Leitung läuft!";
assert_eq!(split_command(test_string3),vec!["Wir#", "$%gehen erst wieder, wenn ihre Leitung läuft!"]);
assert_eq!(split_command(test_string3), vec!["Wir#", "$%gehen erst wieder, wenn ihre Leitung läuft!"]);
} }
#[test] #[test]
fn test_split_command_empty(){assert_eq!(split_command(""),vec!["",""])}
fn test_split_command_empty() {
assert_eq!(split_command(""), vec!["", ""]);
}
#[test] #[test]
fn test_split_command_only_space(){
assert_eq!(split_command(" "),vec!["",""]);
fn test_split_command_only_space() {
assert_eq!(split_command(" "), vec!["", ""]);
} }
} }
Loading…
Cancel
Save