Browse Source

added second test for readConfig & productive code

feature-pr-BordComputer-readConfig
Jan Ortner 3 years ago
parent
commit
0fd42ce65a
  1. 1
      src/main/java/BordComputer.java
  2. 8
      src/test/java/BordComputerTest.java

1
src/main/java/BordComputer.java

@ -12,6 +12,7 @@ public class BordComputer {
properties.load(reader); properties.load(reader);
String[] values = properties.values().toArray(new String[0]); String[] values = properties.values().toArray(new String[0]);
deviceNames = new String[values.length]; deviceNames = new String[values.length];
System.arraycopy(values, 0, deviceNames, 0, properties.size());
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); e.printStackTrace();
} }

8
src/test/java/BordComputerTest.java

@ -15,7 +15,7 @@ class BordComputerTest {
@ParameterizedTest @ParameterizedTest
@MethodSource("readConfigOptions") @MethodSource("readConfigOptions")
void readConfigTest(String testName, String testTyp, BordComputer testBc) {
void readConfigTest(String testName, String testTyp, BordComputer testBc, String expectedResult) {
if (testTyp.equals("count")) { if (testTyp.equals("count")) {
int count = 0; int count = 0;
try (FileReader reader = new FileReader("Geraete.config")) { try (FileReader reader = new FileReader("Geraete.config")) {
@ -27,6 +27,9 @@ class BordComputerTest {
} }
assertThat(count).describedAs(testName).isEqualTo(testBc.deviceNames.length); assertThat(count).describedAs(testName).isEqualTo(testBc.deviceNames.length);
} }
if (testTyp.equals("item1")) {
assertThat(testBc.deviceNames[0]).describedAs(testName).isEqualTo(expectedResult);
}
} }
static Stream<Arguments> readConfigOptions() { static Stream<Arguments> readConfigOptions() {
@ -34,7 +37,8 @@ class BordComputerTest {
bc1.readConfig(); bc1.readConfig();
return Stream.of( return Stream.of(
Arguments.of("Check if file reader is getting every item in Geraete.config", "count", bc1)
Arguments.of("Check if file reader is getting every item in Geraete.config", "count", bc1, ""),
Arguments.of("Check if file reader is getting the first element", "item1", bc1, "device.cdPlayer.CdPlayer")
); );
} }
Loading…
Cancel
Save