From 093a6d3d4aa716157255f18652d72dc0fada1a29 Mon Sep 17 00:00:00 2001 From: fdai7754 Date: Thu, 8 Feb 2024 20:53:32 +0100 Subject: [PATCH 1/2] refactoring: zufallszahlgenerierung in funktion ausgelagert --- src/magiceightball.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/magiceightball.c b/src/magiceightball.c index ef45818..e49720f 100644 --- a/src/magiceightball.c +++ b/src/magiceightball.c @@ -2,9 +2,12 @@ #include #include -int run_magiceightball() { - +int gib_zufallszahl_aus_16() { srand(time(NULL)); + return rand() % 16; +} + +int run_magiceightball() { char antwort[16][100] = { "Ja", @@ -30,7 +33,7 @@ int run_magiceightball() { char fragesatz[100]; fgets(fragesatz, sizeof(fragesatz), stdin); - int randomIndex = rand() % 16; + int randomIndex = gib_zufallszahl_aus_16(); printf("%s\n", antwort[randomIndex]); return 0; From 609cd5663c2b848e9c16f3eff6f96de65595ccd8 Mon Sep 17 00:00:00 2001 From: fdai7754 Date: Thu, 8 Feb 2024 21:09:31 +0100 Subject: [PATCH 2/2] refactoring: variablen zur besseren lesbarkeit umbenannt --- src/minirechner.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/minirechner.c b/src/minirechner.c index 680410b..fc6b532 100644 --- a/src/minirechner.c +++ b/src/minirechner.c @@ -95,22 +95,22 @@ float rest(float a, float b) { // groesster gemeinsammer Teiler float groesster_gemeinsammer_teiler(float a, float b) { - float gr, kl; + float gross, klein; float rest = 1; if (a > b) { - gr = a; - kl = b; + gross = a; + klein = b; } else { - gr = b; - kl = a; + gross = b; + klein = a; } while (rest != 0) { - rest = fmod(gr, kl); - gr = kl; - kl = rest; + rest = fmod(gross, klein); + gross = klein; + klein = rest; } - return gr; + return gross; } // kleinstes gemeinsammes Vielfaches