From 94fcf2b0d9e01cfc97ce3dc26bd8eb70cee5f198 Mon Sep 17 00:00:00 2001 From: fdai7920 Date: Fri, 2 Feb 2024 15:06:39 +0100 Subject: [PATCH] refactoring: update AddPlayerTest --- .../de/hsfulda/onses/PlayerServiceTest.java | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/test/java/de/hsfulda/onses/PlayerServiceTest.java b/src/test/java/de/hsfulda/onses/PlayerServiceTest.java index 08630c6..855ee24 100644 --- a/src/test/java/de/hsfulda/onses/PlayerServiceTest.java +++ b/src/test/java/de/hsfulda/onses/PlayerServiceTest.java @@ -15,11 +15,15 @@ public class PlayerServiceTest { void addPlayerToPlayerList() { //arrange Player input = new Player(); - Player expected = input; + boolean expected = true; + boolean answer = false; // act PlayerService playerservice = new PlayerService(); playerservice.addPlayerToList(input); - Player answer = playerservice.getPlayerList().getFirst(); + for (Player i : playerservice.getPlayerList()) + { + if (i == input) {answer = true; break;} + } // assert assertEquals(expected, answer); } @@ -28,20 +32,24 @@ public class PlayerServiceTest { @DisplayName("addMultiplePlayerToPlayerList") void addMultiplePlayerToPlayerList() { //arrange + boolean expected = true; Player input1 = new Player(); - Player expected1 = input1; + boolean answer1 = false; Player input2 = new Player(); - Player expected2 = input2; + boolean answer2 = false; // act PlayerService playerservice = new PlayerService(); playerservice.addPlayerToList(input1); playerservice.addPlayerToList(input2); - Player answer1 = playerservice.getPlayerList().getFirst(); - Player answer2 = playerservice.getPlayerList().get(1); + for (Player i : playerservice.getPlayerList()) + { + if (i == input1) {answer1 = true;} + if (i == input2) {answer2 = true;} + } // assert - assertEquals(expected1, answer1); - assertEquals(expected2, answer2); + assertEquals(expected, answer1); + assertEquals(expected, answer2); } @Test @DisplayName("checkCurrentTurnAfterNextTurn")