From d90dfd48ad6b34935acb83c1a277e735a027ebe4 Mon Sep 17 00:00:00 2001 From: Alena Bandarovich Date: Wed, 7 Feb 2024 20:26:13 +0100 Subject: [PATCH] Refactor: make PORT a global constant --- src/main/java/ChatClient.java | 8 +++----- src/main/java/Constants.java | 1 + 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/ChatClient.java b/src/main/java/ChatClient.java index 0e2cf51..afa6503 100644 --- a/src/main/java/ChatClient.java +++ b/src/main/java/ChatClient.java @@ -7,7 +7,6 @@ import java.net.Socket; public class ChatClient extends JFrame implements KeyListener { private String address; - private int port; private Socket connectionToServer; private BufferedReader fromServerReader; private PrintWriter toServerWriter; @@ -17,9 +16,8 @@ public class ChatClient extends JFrame implements KeyListener { private JTextField inputTextField; private JScrollPane outputScrollPane; - public ChatClient(int port) { + public ChatClient() { super("Chat"); - this.port = port; address = JOptionPane.showInputDialog("bitte IP-Adresse"); if (address != null) { @@ -48,7 +46,7 @@ public class ChatClient extends JFrame implements KeyListener { } private void receiveMessages() { try { - connectionToServer = new Socket(address, port); + connectionToServer = new Socket(address, Constants.PORT); fromServerReader = new BufferedReader(new InputStreamReader(connectionToServer.getInputStream())); toServerWriter = new PrintWriter(new OutputStreamWriter(connectionToServer.getOutputStream())); @@ -108,6 +106,6 @@ public class ChatClient extends JFrame implements KeyListener { } public static void main(String[] args) { - new ChatClient(3141); + new ChatClient(); } } diff --git a/src/main/java/Constants.java b/src/main/java/Constants.java index 15a8e91..5848138 100644 --- a/src/main/java/Constants.java +++ b/src/main/java/Constants.java @@ -1,4 +1,5 @@ public class Constants { public static final int WINDOW_WIDTH = 800; public static final int WINDOW_HEIGHT = 600; + public static final int PORT = 3141; }