From f1948736400453fed59078051298b55e49a7b725 Mon Sep 17 00:00:00 2001
From: fdai7207 <haytham.daoula@informatik.hs-fulda.de>
Date: Fri, 10 Feb 2023 03:16:09 +0100
Subject: [PATCH] implement unit tests for the isValidAdress() function.

---
 src/createEmployeeAccount.c        | 13 ++++-----
 src/createEmployeeAccount.h        |  7 +++--
 tests/test_createEmployeeAccount.c | 47 +++++++++++++++++++++++++++++-
 3 files changed, 56 insertions(+), 11 deletions(-)

diff --git a/src/createEmployeeAccount.c b/src/createEmployeeAccount.c
index c7fac7c..39f2bac 100644
--- a/src/createEmployeeAccount.c
+++ b/src/createEmployeeAccount.c
@@ -80,20 +80,20 @@ bool isValidPhoneNumber(char *phoneNumber)
     return true;
 }
 
-bool isValidAdress(char *street,int houseNumber,char* city,int postalCode)
+bool isValidAdress(char *street,char* city,int houseNumber,int postalCode)
 {
-    int maximalLength = 20;
-    int minimalLength = 3;
+    int lengthMax = 20;
+    int LengthMin = 3;
     bool validStreet = true;
     bool validHouseNumber = true;
     bool validCity = true;
     bool validpostalCode = true;
-    if(strlen(street)>20 || strlen(street)<3)
+    if(strlen(street)>lengthMax || strlen(street)<LengthMin)
     {
         validStreet = false;
     }
 
-    if(strlen(city)>20 || strlen(city)<3)
+    if(strlen(city)>lengthMax || strlen(city)<LengthMin)
     {
         validCity = false;
     }
@@ -105,11 +105,10 @@ bool isValidAdress(char *street,int houseNumber,char* city,int postalCode)
     {
         validpostalCode = false;
     }
-    if(validStreet && validCity && validHouseNumber && validpostalCode)
+    if(validStreet==true && validCity==true && validHouseNumber==true && validpostalCode==true)
     {
         return true;
     }
-    else
     {
         return false;
     }
diff --git a/src/createEmployeeAccount.h b/src/createEmployeeAccount.h
index 9c67108..f781fa6 100644
--- a/src/createEmployeeAccount.h
+++ b/src/createEmployeeAccount.h
@@ -23,11 +23,12 @@ typedef struct employeesInformations employeedata;
 
 bool isValidEmployeeID(const char* employee, int maximumLength);
 bool isValidPassword( char* password, int minimumLength);
-bool createNewEmployee(char* employeeId, char* employeePassword);
-bool verifyPassword(char* enteredPassword,char* passwordConfirmation);
-bool storeEmployeeData(const char *name,const char *lastName,const char *adress,const char *phoneNumber);
 bool isValidName(char* name,int minimalLength);
 bool isValidPhoneNumber(char *phoneNumber);
+bool isValidAdress(char *street,char* city,int houseNumber,int postalCode);
+bool storeEmployeeData(const char *name,const char *lastName,const char *adress,const char *phoneNumber);
+bool verifyPassword(char* enteredPassword,char* passwordConfirmation);
+bool createNewEmployee(char* employeeId, char* employeePassword);
 
 int StringLengthCounter(char* string);
 
diff --git a/tests/test_createEmployeeAccount.c b/tests/test_createEmployeeAccount.c
index fcd24d3..8fea023 100644
--- a/tests/test_createEmployeeAccount.c
+++ b/tests/test_createEmployeeAccount.c
@@ -240,6 +240,50 @@ void test_validPhoneNumber(void)
     }
 }
 
+void test_isValidAdressSuccess(void)
+{
+    /*Arrange*/
+    char* validStreet[] = {"LeipzigerStrasse","HannauerLandStra","HenirichStrasse","MAgdeburgerStrasse"};
+    char* validCity[] = {"Hannover","Frankfurt","Berlin","Fulda"};
+    int validHouseNumber[4] = {112,365,16,998};
+    int validPostalCode[4] = {36879,36897,12354,9999};
+    bool validAdress[4];
+    
+    /*Act*/
+    for(int i=0;i<4;i++)
+    {
+        validAdress[i] = isValidAdress(validStreet[i],validCity[i],validHouseNumber[i],validPostalCode[i]);
+    }
+
+    /*Assert*/
+    for(int j=0;j<4;j++)
+    {
+        TEST_ASSERT_TRUE(validAdress[j]);
+    }
+
+}
+void test_isValidAdressFailure(void)
+{
+    /*Arrange*/
+    char* invalidStreet[] = {"LeipzigerStrassehvjhb","HannauerLandStranl","bob",".."};
+    char* invalidCity[] = {"log","fiz","foo","bar"};
+    int invalidHouseNumber[4] = {-10,-1,0,99815};
+    int invalidPostalCode[4] = {-1,10,999,65};
+    bool invalidAdress[4];
+    
+    /*Act*/
+    for(int i=0;i<4;i++)
+    {
+        invalidAdress[i] = isValidAdress(invalidStreet[i],invalidCity[i],invalidHouseNumber[i],invalidPostalCode[i]);
+    }
+
+    /*Assert*/
+    for(int j=0;j<4;j++)
+    {
+        TEST_ASSERT_FALSE(invalidAdress[j]);
+    }
+
+}
 void test_invalidPhoneNumber(void)
 {
     /*Arrange*/
@@ -253,6 +297,7 @@ void test_invalidPhoneNumber(void)
         TEST_ASSERT_EQUAL(invalidPhoneNumbersExpectation,invalidPhoneNumbersResult);
     }
     
-}
+} 
+
 
 #endif // TEST