From c06136470d95f0fe7dc0918606a41160cd688053 Mon Sep 17 00:00:00 2001
From: fdai7207 <haytham.daoula@informatik.hs-fulda.de>
Date: Mon, 6 Feb 2023 07:00:49 +0100
Subject: [PATCH] refactoring: improved code readability by removing redundant
 lines, renaming variables and adding comments for documentation.

---
 src/createEmployeeAccount.c | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/src/createEmployeeAccount.c b/src/createEmployeeAccount.c
index 633561f..bb283e0 100644
--- a/src/createEmployeeAccount.c
+++ b/src/createEmployeeAccount.c
@@ -5,7 +5,7 @@
 bool isValidEmployeeID(const char* employeeId, int maximumStringLength)
 {
     int employeeIdLength = strlen(employeeId);
-
+    /* looping through the employeeId string until a space is found to return false or true otherwise*/
     for(int i=0;i<employeeIdLength;i++)
     {
         if(employeeId[i]==' ')
@@ -61,16 +61,9 @@ int StringLengthCounter(char* string)
     return characterCounter;
 }
 
-bool verifyPassword(char* enteredPassword,char* passwordConfirmation)
+bool verifyPassword(char* enteredPassword,char* Confirmation)
 {
-    if(strcmp(enteredPassword,passwordConfirmation)==0)
-    {
-        return true;
-    }
-    else
-    {
-        return false;
-    }
+    return !(strcmp(enteredPassword,Confirmation));
 }
 
 
@@ -97,18 +90,18 @@ bool createNewEmployee(char* employeeId, char* employeePassword)
 void getNewEmployeeCredentials()
 {
     
-    const int Length = 21;
-    char employeeId[Length];
-    const int minimumPasswordLength = 5;
-    char employeePassword[Length];
-    char passwordVerfication[Length];
+    const int maxLength = 21;
+    char employeeId[maxLength];
+    const int minPasswordLength = 5;
+    char employeePassword[maxLength];
+    char passwordVerfication[maxLength];
     printf("please enter your wished Id :\n");
 
     /*Added the regular expression [^\n] so that the string keep on getting read until a newline '\n' is found*/
 
     scanf(" %[^\n]s",employeeId);
    
-    employeeId[Length] = '\0';
+    employeeId[maxLength] = '\0';
     
     printf("\nplease enter your wished Password :\n");
 
@@ -125,12 +118,12 @@ void getNewEmployeeCredentials()
     if(verifyPassword(passwordVerfication,employeePassword))
     {
 
-        if(isValidEmployeeID(employeeId,Length) && isValidPassword(employeePassword,minimumPasswordLength))
+        if(isValidEmployeeID(employeeId,maxLength) && isValidPassword(employeePassword,minPasswordLength))
         {
             createNewEmployee(employeeId,employeePassword) ? printf("\n\n Account created successfully !\n\n") : printf("\n\n Could not create the Account please contact an employee of clearance 1 !\n\n");
         }
 
-        else if(isValidEmployeeID(employeeId,Length) && !isValidPassword(employeePassword,minimumPasswordLength))
+        else if(isValidEmployeeID(employeeId,maxLength) && !isValidPassword(employeePassword,minPasswordLength))
         {
             printf("Error : the entered password should be at least 5 characters long and should contain at least 1 digit, 1 alphabet and 1 symbol!");
         }