From aa532a83b066dfee513b0917d3d7deec4715876d Mon Sep 17 00:00:00 2001 From: fdai7057 Date: Fri, 20 Jan 2023 19:08:26 +0100 Subject: [PATCH] refactoring: replaced variables with arrays and the consecutive use of assertions with for-loops. --- tests/test_LoginCustomer.c | 64 +++++++------------------------------- 1 file changed, 11 insertions(+), 53 deletions(-) diff --git a/tests/test_LoginCustomer.c b/tests/test_LoginCustomer.c index fc23e10..610a847 100644 --- a/tests/test_LoginCustomer.c +++ b/tests/test_LoginCustomer.c @@ -1,63 +1,21 @@ #include #include "LoginCustomer.h" - void setUp(){}; void tearDown(){}; - void test_checkLogin() { /*arrange*/ - - bool test_1_to_true = (4==4); - bool test_2_to_true = (true==true); - bool test_3_to_true = (1==1); - bool test_4_to_true = (false==false); - bool test_5_to_true = ('z'=='z'); - bool test_6_to_true = ('='=='='); - bool test_7_to_true = (0x1A==0x1A); - - bool test_1_to_false = (4!=4); - bool test_2_to_false = (true==false); - bool test_3_to_false = (1==0); - bool test_4_to_false = (false==true); - bool test_5_to_false = ('z'=='x'); - bool test_6_to_false = ('!'==')'); - bool test_7_to_false = (0x1A==0x2B); + bool expected_test_values_compute_to_true[] = {4==4,true==true, 1==1, false==false, 'z'=='z', '='=='=',0x1A==0x1A}; + int length_1 = sizeof(expected_test_values_compute_to_true)/sizeof(bool); - /*act*/ - - bool result_1 = checkLogin(test_1_to_true); - bool result_2 = checkLogin(test_2_to_true); - bool result_3 = checkLogin(test_3_to_true); - bool result_4 = checkLogin(test_4_to_true); - bool result_5 = checkLogin(test_5_to_true); - bool result_6 = checkLogin(test_6_to_true); - bool result_7 = checkLogin(test_7_to_true); - - bool result_8 = checkLogin(test_1_to_false); - bool result_9 = checkLogin(test_2_to_false); - bool result_10 = checkLogin(test_3_to_false); - bool result_11 = checkLogin(test_4_to_false); - bool result_12 = checkLogin(test_5_to_false); - bool result_13 = checkLogin(test_6_to_false); - bool result_14 = checkLogin(test_7_to_false); - - /*assertions*/ - - TEST_ASSERT_TRUE(result_1); - TEST_ASSERT_TRUE(result_2); - TEST_ASSERT_TRUE(result_3); - TEST_ASSERT_TRUE(result_4); - TEST_ASSERT_TRUE(result_5); - TEST_ASSERT_TRUE(result_6); - TEST_ASSERT_TRUE(result_7); - - TEST_ASSERT_FALSE(result_8); - TEST_ASSERT_FALSE(result_9); - TEST_ASSERT_FALSE(result_10); - TEST_ASSERT_FALSE(result_11); - TEST_ASSERT_FALSE(result_12); - TEST_ASSERT_FALSE(result_13); - TEST_ASSERT_FALSE(result_14); + bool expected_test_values_compute_to_false[] = {4!=4,true==false,1==0,false==true,'z'=='x','!'==')',0x1A==0x2B}; + int length_2 = sizeof(expected_test_values_compute_to_false)/sizeof(bool); + /*act and assertions*/ + for(int i=0;i<7;++i) { + TEST_ASSERT_TRUE(checkLogin(expected_test_values_compute_to_true[i])); + } + for(int i=0;i<7;++i){ + TEST_ASSERT_FALSE(checkLogin(expected_test_values_compute_to_false[i])); + } }