From 80b26f2a6dba01794228bf6653ae191eaf111683 Mon Sep 17 00:00:00 2001
From: fdai7207 <haytham.daoula@informatik.hs-fulda.de>
Date: Tue, 7 Feb 2023 23:09:08 +0100
Subject: [PATCH] implement unit tests for the new function isvalidName().

---
 src/createEmployeeAccount.c        | 19 ++++++++++++
 src/createEmployeeAccount.h        |  1 +
 tests/test_createEmployeeAccount.c | 50 +++++++++++++++++++++++++++++-
 3 files changed, 69 insertions(+), 1 deletion(-)

diff --git a/src/createEmployeeAccount.c b/src/createEmployeeAccount.c
index 47c6eb9..b298929 100644
--- a/src/createEmployeeAccount.c
+++ b/src/createEmployeeAccount.c
@@ -48,6 +48,24 @@ bool isValidPassword( char *password, int minimumLength)
 
 }
 
+bool isValidName(char* name, int minimalLength)
+{
+    if(strlen(name) < minimalLength)
+    {
+        return false;
+    }
+
+    for(int i = 0;i<strlen(name);i++)
+    {
+        if(isdigit(name[i])||ispunct(name[i])||isspace(name[i]))
+        {
+            return false;
+        }
+
+    }
+    return true;
+}
+
 int StringLengthCounter(char* string)
 {
     int characterCounter = 0;
@@ -112,6 +130,7 @@ void getNewEmployeeCredentials()
     const int maxLength = 21;
     char employeeId[maxLength];
     const int minPasswordLength = 5;
+    const int minimumNameLength = 4;
     char employeePassword[maxLength];
     char passwordVerfication[maxLength];
 
diff --git a/src/createEmployeeAccount.h b/src/createEmployeeAccount.h
index ca94af0..ddd1dfe 100644
--- a/src/createEmployeeAccount.h
+++ b/src/createEmployeeAccount.h
@@ -21,6 +21,7 @@ bool isValidPassword( char* password, int minimumLength);
 bool createNewEmployee(char* employeeId, char* employeePassword);
 bool verifyPassword(char* enteredPassword,char* passwordConfirmation);
 bool storeEmployeeData(const char *name,const char *lastName,const char *adress,const char *phoneNumber);
+bool isValidName(char* name,int minimalLength);
 
 int StringLengthCounter(char* string);
 
diff --git a/tests/test_createEmployeeAccount.c b/tests/test_createEmployeeAccount.c
index 4db4ca1..f6504b3 100644
--- a/tests/test_createEmployeeAccount.c
+++ b/tests/test_createEmployeeAccount.c
@@ -147,7 +147,7 @@ void test_verifyPasswordFailure()
 void test_employeesDataStoringSuccess(void)
 {
     /*Arrange*/
-    char*data[][4] ={
+    char* data[][4] ={
                         {"John","Doe","fulda,leipzigerstr12","+4926428421469"},
                         {"Jane","Done","fulda,leipzigerstr13","+4932517359874"},
                         {"Foo","Bar","fulda,leipzigerstr14","+4913598765315"},
@@ -190,4 +190,52 @@ void test_employeeCreatedSuccessfully(void)
 
 }
 
+void test_validName(void)
+{
+    /*Arrange*/
+
+    char* validNames[] = {"John","Jane","Fizz","Foo","Atharva","Can","Julius","Haytham","Mohamed","Shivam"};
+    int minimalLength = 4;
+    bool validNamesResult[10];
+
+    /*Act*/
+
+    for(int i = 0;i<10;i++)
+    {
+        validNamesResult[i] = isValidName(validNames[i],minimalLength);
+    }
+
+    /*Assert*/
+
+    for(int i = 0;i<10;i++)
+    {
+        TEST_ASSERT_TRUE(validNames[i]);
+    }
+
+}
+
+void test_invalidName(void)
+{
+    /*Arrange*/
+
+    char* invalidNames[] = {"Jo hn","Jane.","Fizz36","Foo8","Ath,arva","C .a1n","Jul132ius","123Haytham",".Mohamed"," Shivam"};
+    int minimalLength = 4;
+    bool invalidNamesResult[10];
+
+    /*Act*/
+
+    for(int i = 0;i<10;i++)
+    {
+        invalidNamesResult[i] = isValidName(invalidNames[i],minimalLength);
+    }
+
+    /*Assert*/
+
+    for(int i = 0;i<10;i++)
+    {
+        TEST_ASSERT_FALSE(invalidNamesResult[i]);
+    }
+
+}
+
 #endif // TEST