From 25b42cd0c06a5d25a91576fb4b64d5f7cc387c94 Mon Sep 17 00:00:00 2001
From: fdai7207 <haytham.daoula@informatik.hs-fulda.de>
Date: Sun, 5 Feb 2023 06:52:53 +0100
Subject: [PATCH] refactoring: changed some variabales names in
 createEmployeeAccount.c for better readability.

---
 src/createEmployeeAccount.c | 28 +++++++++++++++-------------
 src/createEmployeeAccount.h |  2 +-
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/src/createEmployeeAccount.c b/src/createEmployeeAccount.c
index 8532456..ab4f38a 100644
--- a/src/createEmployeeAccount.c
+++ b/src/createEmployeeAccount.c
@@ -17,18 +17,18 @@ int StringLengthCounter(char* string)
 }
 
 
-bool isValidEmployeeID(char* employeeId, int maximumLength)
+bool isValidEmployeeID(const char* employeeId, int maximumStringLength)
 {
     int employeeIdLength = strlen(employeeId);
-    int i;
-    for(i=0;i<employeeIdLength;i++)
+
+    for(int i=0;i<employeeIdLength;i++)
     {
         if(employeeId[i]==' ')
         {
             return false;
         }
     }
-        return employeeIdLength <= maximumLength ;
+    return employeeIdLength <= maximumStringLength ;
 }
 
 bool createNewEmployee(char* employeeId, char* employeePassword)
@@ -54,25 +54,27 @@ bool createNewEmployee(char* employeeId, char* employeePassword)
 void getNewEmployeeCredentials()
 {
     
-    int newEmployeeIdlength = 21;
-    char newEmployeeId[newEmployeeIdlength];
-    char newEmployeePassword[newEmployeeIdlength];
+    const int employeeIdlength = 21;
+    char employeeId[employeeIdlength];
+    char employeePassword[employeeIdlength];
 
     printf("please enter your wished Id :\n");
 
-    scanf(" %[^\n]s",newEmployeeId);
+    /*Added the regular expression [^\n] so that the string keep on getting read until a newline '\n' is found*/
+
+    scanf(" %[^\n]s",employeeId);
    
-    newEmployeeId[newEmployeeIdlength] = '\0';
+    employeeId[employeeIdlength] = '\0';
     
     printf("\nplease enter your wished Password :\n");
 
-    scanf("%s",newEmployeePassword);
+    scanf("%s",employeePassword);
 
-    newEmployeePassword[newEmployeeIdlength] = '\0';
+    employeePassword[employeeIdlength] = '\0';
 
-    if(isValidEmployeeID(newEmployeeId,newEmployeeIdlength))
+    if(isValidEmployeeID(employeeId,employeeIdlength))
     {
-        createNewEmployee(newEmployeeId,newEmployeePassword) ? printf("\n\n Account created successfully !\n\n") : printf("\n\n Could not create the Account please contact an employee of clearance 1 !\n\n");
+        createNewEmployee(employeeId,employeePassword) ? printf("\n\n Account created successfully !\n\n") : printf("\n\n Could not create the Account please contact an employee of clearance 1 !\n\n");
     }
 
     else
diff --git a/src/createEmployeeAccount.h b/src/createEmployeeAccount.h
index 05bf169..22cf4d7 100644
--- a/src/createEmployeeAccount.h
+++ b/src/createEmployeeAccount.h
@@ -6,7 +6,7 @@
 #include<stdbool.h>
 #include<string.h>
 
-bool isValidEmployeeID(char* employee, int maximumLength);
+bool isValidEmployeeID(const char* employee, int maximumLength);
 bool createNewEmployee(char* employeeId, char* employeePassword);
 
 int StringLengthCounter(char* string);