From 46efd787345dbbb814eaef6d11ba60e23ff42f99 Mon Sep 17 00:00:00 2001
From: Sheogorath <sheogorath@shivering-isles.com>
Date: Wed, 17 Jul 2019 22:01:36 +0200
Subject: [PATCH] Fix nickname error responses to match RFC

---
 src/server.js        | 4 ++--
 test/command_nick.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/server.js b/src/server.js
index 0d12a46..7c89dbd 100644
--- a/src/server.js
+++ b/src/server.js
@@ -57,12 +57,12 @@ server.create = function create(config = {}) {
                                 user.setNickname(nickname)
                                 userlist[user.nickname] = user
                             } else {
-                                socket.write(ERR_NICKNAMEINUSE, " nickname in use")
+                                socket.write(`:irc.example.com ${ERR_NICKNAMEINUSE} ${nickname} :Nickname is already in use`, 'ascii')
                             }
 
 
                         } else {
-                            socket.write(ERR_NONICKNAMEGIVEN, "ERROR: NO NICKNAME PROVIDED")
+                            socket.write(`:irc.example.com ${ERR_NONICKNAMEGIVEN} :No nickname given`, 'ascii')
                         }
 
                         break;
diff --git a/test/command_nick.js b/test/command_nick.js
index 19b0fd1..7c7e720 100644
--- a/test/command_nick.js
+++ b/test/command_nick.js
@@ -31,7 +31,7 @@ describe("NICK already registered", function () {
         }
         let mockedSock2 = new EventEmitter()
         mockedSock2.write = function (data) {
-            assert.equal(data.toString("ascii"), "433")
+            assert.equal(data.toString("ascii"), ":irc.example.com 433 some_nick :Nickname is already in use")
             done()
         }
         mockedSock2.destroy = function () {
@@ -49,7 +49,7 @@ describe("NICK no NICK given", function () {
         const server = IRCServer.create()
         let mockedSock = new EventEmitter()
         mockedSock.write = function (data) {
-            assert.equal(data.toString("ascii"), "431")
+            assert.equal(data.toString("ascii"), ":irc.example.com 431 :No nickname given")
             done()
         }
         mockedSock.destroy = function () {